Separate drags from drops in stopEvent

[thatsjonsense]

Problem

When you try to drop something on the edges of a NodeView, outside the contentDOM, it looks like it should be droppable because dropCursor shows a line in the correct place. But it doesn't actually go through, or it goes through as a copy instead of a move, because stopEvent triggers and prevents the drop event from propagating effectively.

More details: ProseMirror/prosemirror#1208

Solution

Separate the logic for handling drag events from drop events

[philippkuehn]

Can you tell me why this is related to the isInput check?

[thatsjonsense]

The following line will stop any event that matches this isInput check. But I found that all drops were being classified as inputs because this check is so broad, just because they landed inside inside the content editable. This prevents ProseMirror's handleDrop from running. handleDrop is what removes the original slice after you drop. Without this change, it would always duplicate.

An alternative would be to change the line below to

    if (isInput && !isDropEvent) {
      return true
    }

[philippkuehn]

Ah right, that isContentEditable check initially was for detecting nested editors. Maybe I have to improve that.

An alternative would be to change the line below to
if (isInput && !isDropEvent) {
return true
}

better!

And do you think this is related to #1938?

[thatsjonsense]

Yea, I have a feeling #1938 would be solved by the change on line 169 below to always return false if it's a drop event

[philippkuehn]

great! thanks!