-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ReactRenderer
types
#2011
Improve ReactRenderer
types
#2011
Conversation
Thanks for the effort! We decided to not use TypeScript in the examples though. My impression is that only 10 % or less use TypeScript, and they are confused by something they don’t know, but TS users are able to add types on their own. @philippkuehn What do you think? |
That's understandable, I can revert the example to JavaScript, no problem. However, this PR also fixes a few types in
Except for the errors I posted in the OP, which I have no idea how to fix 😅 Do you think you can help me with that? Maybe further changes to the source types are required? 🤔 |
Same!
Looks good to me. Could you please update the PR to contain only these changes or create a new one? |
Yes, I can update the PR, but those errors need to be fixed first. They show that the changes I'm making here are not finished/correct. |
@rfgamaral I fixed another type issue in ReactRenderer right now. I think you stumbled across that issue too. |
@philippkuehn Pulled your changes, pushed them to this PR, and you can see that there's still one error that needs fixing: |
This is because of conflicting types for our demos since we mix vue and react demos. since we don't want to use TS for our demos we can ignore this for now. |
ReactRenderer
types
@philippkuehn I've updated the PR, and reverted the TS examples back to JS. Only |
Thank you! |
This is an attempt to convert the "Mentions" community example to TypeScript. I'm still new to tiptap's codebase, so forgive me if I'm not doing things properly.
Unfortunately I wasn't able to fix every error, so this PR is a bit incomplete. I'm hoping someone can help me figure out the remaining bits: