Use ref to move contentDOM #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The If I understand this PR correctly, you've come to a similar approach (remove the hacky queryselector) as https://github.com/ueberdosis/tiptap/pull/1470/files, but use Context as a way to pass the ref, instead of forcing consumers to pass along the ref. Your approach has the advantage that it doesn't change the API, at the cost of a little less easy to grasp pattern using Context. I think that's a fair trade-off so if this has been tested well, I'd suggest to merge it! |
|
@YousefED thanks! :) |
andrewlu0
pushed a commit
to trybaseplate/tiptap
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling
maybeMoveContentDOMmanually, we are using aref.fixes #1942, which was broken because of this patch (which was a fix for #1747). #1747 is still fixed with this PR.
@YousefED I had to remove
forwardRefforNodeViewContent(which was a merged PR from you) for that so I would like to hear you thoughts about this change. I’m still not quite sure what you needed this ref for. Can you give me an example?