Doc fix: Remove braces from isEmpty & isEditable #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! I've updated the docs to make it more clear that `editor.isEmpty` and `editor.isEditable` are bools rather than functions that need called. This is a quick fix and I'd recommend these maybe be moved out of the "methods" section of the docs, but as of right now there's no obvious section to move them to, and I don't want to make assumptions about what these should be called.
|
Oh, yes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've updated the docs to make it more clear that
editor.isEmptyandeditor.isEditableare bools rather than functions that need called.This is a quick fix and I'd recommend these maybe be moved out of the "methods" section of the docs, but as of right now there's no obvious section to move them to, and I don't want to make assumptions about what these should be called.