Include children in placeholder plugin #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option to the placeholder plugin to include children in the search for empty nodes.
|
Oh sorry for that delay. Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to the placeholder plugin to include children in the search for empty nodes.
Consider the use case in which there is a
headernode withtitleandsubtitlenodes. Currently, the header node will be the only one that receives the.is-emptyclass. Therefore, typing something into the title node makes the subtitle placeholder disappear, which is confusing to users. With the modifications in this PR, the search for empty nodes can be continued to children. Therefore, the subtitle node would retain its placeholder until modified.I'd like to get some feedback on this before updating the docs and such.