[Bug]: In addOptions. the type of this.parent is wrong.

[mgreystone]

Affected Packages

core

Version(s)

2.9.1

Bug Description

When extending a node & implementing addOptions, the type of this.parent is incorrect.

For a Node<T>, this.parent is typed as () => T, denoting that it is safe to call directly like this.parent(). However, this.parent might be undefined, as is documented, so we must call this.parent?.().

Because of the inaccurate type, it is easy to forget to add the ?. optional chaining. Furthermore, linting rules such as no-unnecessary-condition can automatically strip the ?. out, which can cause type errors be thrown at runtime.

import { Heading, type Level } from '@tiptap/extension-heading'

const MyHeading = Heading.extend({
  addOptions() {
    const levels: Level[] = [1,2,3]
    return {
      ...this.parent(), // this throws even though typescript says it is safe
      levels,
    }
  }
})

Browser Used

Chrome

Code Example URL

No response

Expected Behavior

In the addOptions method, this.parent should have a type of (() => T) | undefined to match the implementation & documentation.

Additional Context (Optional)

No response

Dependency Updates

• Yes, I've updated all my dependencies.

[nperez0111]

Yep, you are right here. Pushing a patch for it