Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: HTML output of Table is missing colgroup element #4280

Closed
1 of 2 tasks
diginikkari opened this issue Aug 2, 2023 · 0 comments · Fixed by #4281
Closed
1 of 2 tasks

[Bug]: HTML output of Table is missing colgroup element #4280

diginikkari opened this issue Aug 2, 2023 · 0 comments · Fixed by #4281
Assignees
@bdbch @svenadlung
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug

Comments

@diginikkari
Copy link
Contributor

Which packages did you experience the bug in?

extension-table

What Tiptap version are you using?

2.0.4

What’s the bug you are facing?

When using resizable Table, table columns can be resized. This is working with editor. When outputing html from editor
using e.g. editor.getHTML() or generateHTML, rendered table is not including required colgroup element.

What browser are you using?

Chrome

Code example

No response

What did you expect to happen?

I'm expecting rendered html to include colgroup element.

Anything to add? (optional)

I will try to create pull request with fix.

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@diginikkari diginikkari added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug labels Aug 2, 2023
diginikkari added a commit to diginikkari/tiptap that referenced this issue Aug 2, 2023
@diginikkari
[Bug]: HTML output of Table is missing colgroup element
9bc3365 
Fixes ueberdosis#4280
@diginikkari diginikkari mentioned this issue Aug 2, 2023
Merged
4 tasks
bdbch pushed a commit that referenced this issue Oct 10, 2023
@diginikkari
[Bug]: HTML output of Table is missing colgroup element (#4281)
6b2edc5 
* [Bug]: HTML output of Table is missing colgroup element
Fixes #4280

* Fixed typo and added some documentation
@fujita-h fujita-h mentioned this issue Jan 2, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdbch bdbch

@svenadlung svenadlung

Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug
Projects
Tiptap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bug]: HTML output of Table is missing colgroup element diginikkari/tiptap
3 participants
@diginikkari @bdbch @svenadlung