Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordered list start support broke in #3541 / v2.0.0-beta.220 #3831

Closed
1 of 2 tasks
javan opened this issue Mar 7, 2023 · 0 comments · Fixed by #3833
Closed
1 of 2 tasks

Ordered list start support broke in #3541 / v2.0.0-beta.220 #3831

javan opened this issue Mar 7, 2023 · 0 comments · Fixed by #3833
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@javan
Copy link

javan commented Mar 7, 2023

What’s the bug you are facing?

Typing a number > 1 (e.g. 2) followed by . no longer creates an <ol start="…">.

For example, typing…

2. two
3. three

…no longer outputs…

<ol start="2">
  <li>two</li>
  <li>three</li>
</ol>

This can be seen here in GitHub with the same input quoted below:

  1. two
  2. three

Which browser was this experienced in? Are any special extensions installed?

All browsers

How can we reproduce the bug on our side?

Use the text shortcut to create an ordered list with a number > 1 in an editor running v2.0.0-beta.220.

👀

2023-03-07 at 09 50 03

This worked in v2.0.0-beta.219 prior to #3541 being merged.

Can you provide a CodeSandbox?

No response

What did you expect to happen?

The resulting ordered list is numbered as typed. Typing 2. two should generate <ol start="2"><li>two</li></ol>.

Anything to add? (optional)

I’m fairly certain this change is the cause:

2023-03-07 at 09 55 35

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@javan javan added the Type: Bug The issue or pullrequest is related to a bug label Mar 7, 2023
bdbch pushed a commit that referenced this issue Mar 18, 2023
* fix: #3831

* fix: default attribute + predicate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant