Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@tiptap/starter-kit needs a dependency on @tiptap/pm #3746

Closed
1 of 2 tasks
Naddiseo opened this issue Feb 14, 2023 · 4 comments
Closed
1 of 2 tasks

@tiptap/starter-kit needs a dependency on @tiptap/pm #3746

Naddiseo opened this issue Feb 14, 2023 · 4 comments
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@Naddiseo
Copy link

What’s the bug you are facing?

When using yarn, as of version beta-205 when the peerDependencies were added, yarn started complaining that @tiptap/starter-kit doesn't provide @tiptap/pm:

yarn add @tiptap/react @tiptap/pm @tiptap/starter-kit @tiptap/extension-color @tiptap/extension-text-style
➤ YN0000: ┌ Resolution step
➤ YN0002: │ @app@workspace:. doesn't provide @tiptap/core (pe9703), requested by @tiptap/extension-color
➤ YN0002: │ @app@workspace:. doesn't provide @tiptap/core (p1d459), requested by @tiptap/extension-text-style
➤ YN0002: │ @app@workspace:. doesn't provide @tiptap/core (p5a2b6), requested by @tiptap/pm
➤ YN0002: │ @app@workspace:. doesn't provide @tiptap/core (pd2b52), requested by @tiptap/react
➤ YN0002: │ @tiptap/starter-kit@npm:2.0.0-beta.217 doesn't provide @tiptap/pm (p625a0), requested by @tiptap/core
➤ YN0002: │ @tiptap/starter-kit@npm:2.0.0-beta.217 doesn't provide @tiptap/pm (pe2f09), requested by @tiptap/extension-code-block
➤ YN0002: │ @tiptap/starter-kit@npm:2.0.0-beta.217 doesn't provide @tiptap/pm (p75487), requested by @tiptap/extension-dropcursor
➤ YN0002: │ @tiptap/starter-kit@npm:2.0.0-beta.217 doesn't provide @tiptap/pm (pfd7ed), requested by @tiptap/extension-gapcursor
➤ YN0002: │ @tiptap/starter-kit@npm:2.0.0-beta.217 doesn't provide @tiptap/pm (p17b8a), requested by @tiptap/extension-history
➤ YN0002: │ @tiptap/starter-kit@npm:2.0.0-beta.217 doesn't provide @tiptap/pm (p5659a), requested by @tiptap/extension-horizontal-rule
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code

I had a look at the documentation for YN0002, and it describes the issue that transient dependencies need to satisfied by the parent dependency. Since the dependencies of starter-kit have a peerDependency on @tiptap/pm, then starter-kit needs to have it as a dependency

Which browser was this experienced in? Are any special extensions installed?

n/a

How can we reproduce the bug on our side?

using yarn 3 in a blank project:

$ yarn add @tiptap/react @tiptap/pm @tiptap/starter-kit @tiptap/extension-color @tiptap/extension-text-style

Can you provide a CodeSandbox?

No response

What did you expect to happen?

There should be no warnings

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@Naddiseo Naddiseo added the Type: Bug The issue or pullrequest is related to a bug label Feb 14, 2023
@Naddiseo
Copy link
Author

A workaround I've found for now is to add the following to my .yarnrc.yml

packageExtensions:
  "@tiptap/starter-kit@*":
    peerDependencies:
      "@tiptap/pm": "*"

@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Info: Stale The issue or pullrequest has not been updated in a while and might be stale label May 16, 2023
@Naddiseo
Copy link
Author

as far as I can tell this is still an issue

@nperez0111
Copy link
Contributor

Will resolve this in the next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
Status: Done
Development

No branches or pull requests

2 participants