-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table crashes when combined with CharacterCount #1550
Comments
@yellow1912 All packages include the core, the typical development setup (webpack, rollup …) will make sure to include the code only once. That’s called tree-shaking. You need to look at your bundle size, not the individual package size. |
I added a temporary fix in my repo. I disabled the character limit when paired with tables for now. I'd still check here for updates if ever a proper fix is suggested though. Thanks! |
…#1049, fix #1550, fix #1839, fix #2245 * fix a bug when exceeding the character limit * find a better way to limit the doc size * check paste events * add storage method * refactoring * use textBetween instead of textContent * return early if no limit is set * add words method to storage * show word count in charactercount demo Co-authored-by: Philipp Kühn <philippkuehn@MacBook-Pro-von-Philipp.local>
Description
The app crashes as soon as the set limit for character count is reached. But this behavior only happens when Table is used with CharacterCount.
Steps to reproduce the bug
Steps to reproduce the behavior:
Github Repo
I created a Github repo to help you debug the issue:
Expected behavior
As seen in the attached video, the app crashes when the limit is reached.
Screenshot, video, or GIF
tiptapdemo-2021-07-07_21.20.33.mp4
Environment?
The text was updated successfully, but these errors were encountered: