fix(typography): require spaces after divisions to not break date for…

…mats
ueberdosis · Dec 14, 2023 · bf7ff81 · bf7ff81
1 parent e66160d
commit bf7ff81
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/demos/src/Extensions/Typography/React/index.spec.js b/demos/src/Extensions/Typography/React/index.spec.js
@@ -9,6 +9,15 @@ context('/src/Extensions/Typography/React/', () => {
     })
   })
 
+  it('should keep dates as they are', () => {
+    cy.get('.tiptap').type('1/4/2024').should('contain', '1/4/2024')
+  })
+
+  it('should make a fraction only with spaces afterwards', () => {
+    cy.get('.tiptap').type('1/4').should('contain', '1/4')
+    cy.get('.tiptap').type('{selectall}{backspace}1/4 ').should('contain', '¼')
+  })
+
   it('should make an em dash from two dashes', () => {
     cy.get('.tiptap').type('-- emDash').should('contain', '— emDash')
   })

diff --git a/packages/extension-typography/src/typography.ts b/packages/extension-typography/src/typography.ts
@@ -86,7 +86,7 @@ export const registeredTrademark = (override?: string) => textInputRule({
 })
 
 export const oneHalf = (override?: string) => textInputRule({
-  find: /(?:^|\s)(1\/2)$/,
+  find: /(?:^|\s)(1\/2)\s$/,
   replace: override ?? '½',
 })
 
@@ -126,12 +126,12 @@ export const superscriptThree = (override?: string) => textInputRule({
 })
 
 export const oneQuarter = (override?: string) => textInputRule({
-  find: /(?:^|\s)(1\/4)$/,
+  find: /(?:^|\s)(1\/4)\s$/,
   replace: override ?? '¼',
 })
 
 export const threeQuarters = (override?: string) => textInputRule({
-  find: /(?:^|\s)(3\/4)$/,
+  find: /(?:^|\s)(3\/4)\s$/,
   replace: override ?? '¾',
 })