Skip to content

Commit

Permalink
fix(extension-task-item): more flexible inputs for parsing
Browse files Browse the repository at this point in the history
  • Loading branch information
baseballyama authored and nperez0111 committed Jul 18, 2024
1 parent 46079c2 commit b47df57
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/serious-foxes-decide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tiptap/extension-task-item": patch
---

allow task items to be parsed when only having `<li data-checked` instead of only when `<li data-checked="true"`
6 changes: 5 additions & 1 deletion packages/extension-task-item/src/task-item.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ export const TaskItem = Node.create<TaskItemOptions>({
checked: {
default: false,
keepOnSplit: false,
parseHTML: element => element.getAttribute('data-checked') === 'true',
parseHTML: element => {
const dataChecked = element.getAttribute('data-checked')

return dataChecked == null || dataChecked === 'true'
},
renderHTML: attributes => ({
'data-checked': attributes.checked,
}),
Expand Down

0 comments on commit b47df57

Please sign in to comment.