fix(extension-placeholder) Fix perf issue w/empty nodes

ueberdosis · Oct 27, 2022 · 5b60278 · 5b60278
1 parent 2b69f34
commit 5b60278
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/extension-placeholder/src/placeholder.ts b/packages/extension-placeholder/src/placeholder.ts
@@ -44,14 +44,18 @@ export const Placeholder = Extension.create<PlaceholderOptions>({
               return null
             }
 
+            // Calculate isEmpty once due to its performance impace (see issue #3360)
+            const emptyDocInstance = doc.type.createAndFill()
+            const isEditorEmpty = emptyDocInstance?.sameMarkup(doc) && emptyDocInstance.content.findDiffStart(doc.content) === null
+
             doc.descendants((node, pos) => {
               const hasAnchor = anchor >= pos && anchor <= (pos + node.nodeSize)
               const isEmpty = !node.isLeaf && !node.childCount
 
               if ((hasAnchor || !this.options.showOnlyCurrent) && isEmpty) {
                 const classes = [this.options.emptyNodeClass]
 
-                if (this.editor.isEmpty) {
+                if (isEditorEmpty) {
                   classes.push(this.options.emptyEditorClass)
                 }