Skip to content

Commit

Permalink
chore: update typings to not conflict with globals
Browse files Browse the repository at this point in the history
  • Loading branch information
@nperez0111
nperez0111 committed Jul 19, 2024
1 parent 4cca382 commit 3b67e8a
Show file tree
Hide file tree
Showing 3 changed files with 242 additions and 239 deletions.
5 changes: 5 additions & 0 deletions .changeset/rotten-geckos-notice.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---

This comment has been minimized.

Sign in to view

Copy link
@rajsite

rajsite Jul 19, 2024 •
edited
Loading

@nperez0111 Was in the process of filing an issue about this but will hold off since it looks like it's being addressed (unless y'all would like one).

Caused problems with our custom elements that extend HTMLElement and happened to have a property of the same name. We worked around it by renaming our property but glad a fix is already on the way in!
"@tiptap/core": patch
---

This changes the typing to not declare types on all HTMLElements, just a local one with the editor instance attached
Loading

0 comments on commit 3b67e8a

Please sign in to comment.