Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote swaps promoted song with first song instead of shifting the queue #30

Closed
udoprog opened this issue Apr 19, 2019 · 1 comment
Closed

promote swaps promoted song with first song instead of shifting the queue #30

udoprog opened this issue Apr 19, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@udoprog
Copy link
Owner

udoprog commented Apr 19, 2019 •
edited
Loading

Currently !song promote <number> swaps the promoted song with the first song instead of putting it at the head of the queue.

CC: @louis6321 @Jqnxyz
@udoprog udoprog added the bug Something isn't working label Apr 19, 2019
@udoprog
Copy link
Owner Author

udoprog commented Apr 19, 2019

Mentoring instructions. This is not supposed to be a swap:
https://github.com/udoprog/setmod/blob/master/bot/src/player.rs#L1145

udoprog added a commit that referenced this issue Apr 20, 2019
@udoprog
Merge pull request #31 from Jqnxyz/master
84db2fd 
Fix song promote (fixes #30)
udoprog pushed a commit that referenced this issue Apr 22, 2019
@udoprog
Fix song promote (fixes #30)
5a8e4e2 
Updated player.rs to move songs to front of queue instead of swapping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@udoprog