Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync the state of the remote player #18

Closed
udoprog opened this issue Mar 27, 2019 · 4 comments
Closed

Sync the state of the remote player #18

udoprog opened this issue Mar 27, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@udoprog
Copy link
Owner

udoprog commented Mar 27, 2019

With the new connect-based player, the player is immediately paused when it starts up to get into a consistent state.

We could instead poll the state of the player, and use that to initialize the bot state.
@udoprog udoprog added the enhancement New feature or request label Mar 31, 2019
udoprog added a commit that referenced this issue Apr 1, 2019
@udoprog
Sync state of the player with Spotify on startup (related #18)
d0bde83
@udoprog
Copy link
Owner Author

udoprog commented Apr 2, 2019

SetMod can now be configured to sync the remote state of the player with the following configuration option:

[player]
sync_player_interval = "10s"

You probably wan't to keep the interval high, since it will be calling the Spotify API for every check.

@udoprog udoprog changed the title Poll for the state of the current song instead of pausing the player on startup Sync the state of the remote player Apr 2, 2019
@udoprog
Copy link
Owner Author

udoprog commented Apr 2, 2019

There's currently one known bug:

If you switch the song on the Spotify player, it will be noted in SetMod, but immediately afterwards it will reset the song state so that the track shows as not loaded until it has had an oppurtunity to refresh:

image

udoprog added a commit that referenced this issue Apr 2, 2019
@udoprog
Sync the state of the remote player (related to #18)
6a8779c
udoprog added a commit that referenced this issue Apr 2, 2019
@udoprog
Sync the state of the remote player (related to #18)
0a81fab
udoprog added a commit that referenced this issue Apr 2, 2019
@udoprog
Sync the state of the remote player (related to #18)
f244b7f
@udoprog
Copy link
Owner Author

udoprog commented Apr 2, 2019

Seems like the bug has been fixed!

@udoprog
Copy link
Owner Author

udoprog commented Jun 8, 2019

Done.

@udoprog udoprog closed this as completed Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@udoprog