Fix building on OpenBSD big endian hosts #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if it is a function, then !defined(swap16) will not detect it, unless it is actually a macro? a more robust fix would be to rename the function in openjpeg as opj_swap16 |
Yes, in the header it is a macro. Ya, I was just going to post the other option was to rename the function in openjpeg, which is what most projects tend to do. |
There is a swap16() function which conflicts with such a macro in the endian.h header. uint16_t swap16(uint16_t val16); Do as suggested and rename the function to opj_swap16().
bob-beck
pushed a commit
to openbsd/ports
that referenced
this pull request
Mar 5, 2024
- use https HOMEPAGE - bump major - cf https://github.com/uclouvain/openjpeg/blob/v2.5.2/CHANGELOG.md#v252-2024-02-28 & https://github.com/uclouvain/openjpeg/blob/v2.5.2/CHANGELOG.md#v251-2024-02-26 for details, including CVE-2021-3575 - drop now unneeded patches, last one remaining upstreamed in uclouvain/openjpeg#1520 - similar diff sent by brad tested in a bulk by tb@
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a swap16() function which conflicts with such a macro
in the endian.h header. uint16_t swap16(uint16_t val16);