Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: error out on warnings for strict/missing prototypes. #1462

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

sebras
Copy link
Contributor

@sebras sebras commented Mar 9, 2023

And fix strict-prototypes/missing-prototypes warnings.

@rouault
Copy link
Collaborator

rouault commented Mar 9, 2023

@sebras errors for the mingw_64 target are at https://my.cdash.org/viewBuildError.php?buildid=2301396

@sebras sebras force-pushed the master branch 2 times, most recently from aaef606 to 4ee8bdc Compare March 9, 2023 19:03
@sebras
Copy link
Contributor Author

sebras commented Mar 9, 2023

errors for the mingw_64 target are at https://my.cdash.org/viewBuildError.php?buildid=2301396

I know, I found them. I've fixed one of them, but the error relating to DllMain is puzzling to me (I'm mainly a Linux developer). :)

And fix strict-prototypes/missing-prototypes warnings.
@rouault
Copy link
Collaborator

rouault commented Mar 9, 2023

perhaps try the following change:

diff --git a/src/lib/openjp2/openjpeg.c b/src/lib/openjp2/openjpeg.c
index 29d3ee52..561e603d 100644
--- a/src/lib/openjp2/openjpeg.c
+++ b/src/lib/openjp2/openjpeg.c
@@ -33,6 +33,7 @@
 
 #ifdef _WIN32
 #include <windows.h>
+#include <process.h>
 #endif /* _WIN32 */
 
 #include "opj_includes.h"

@sebras
Copy link
Contributor Author

sebras commented Mar 9, 2023

I'll just follow the lead of cairo and declare DllMain locally in the file.
This should avoid the warning/error, and I can't forsee that it would create any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants