More overflow related bug fixes #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…press, opj_dump. See comment on commit 79c7d7a.
Removed automatically generated settings.json
This reverts commit e74ee84.
…d for conformity, relocated check for num images for exicution before allocation and image loading
This reverts commit dbe64d6.
… unsigned for conformity, relocated check for num images for exicution before allocation and image loading" This reverts commit ab6c7c7.
Added overflow protection in get_num_images function, redefined num_images to unsigned int in compress and decompress to match dump
…t exicution of allocation and strcpy if there are no images.
…lue for get_num_images
Eharve14
commented
Jan 18, 2022
ok, I don't think there was any issue in practice because the maximum number of components in a JPEG2000 file is 16384 and this is normally checked before |
|
If that check is always done, I agree that the change is not necessary. I made the edit because that check is not in the function with the iterator in the loop in question, and I did not do the leg work to ensure the check is present before every call to this function. Also this is the only loop in that section of code with the type mismatch between the iterator and comparator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran through the open security issues identified by LGTM code analysis and added fixes for the relevant issues.