Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several potential vulnerabilities #1185

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Fix several potential vulnerabilities #1185

merged 2 commits into from
Apr 26, 2019

Commits on Apr 15, 2019

  1. convertbmp: detect invalid file dimensions early 

    width/length dimensions read from bmp headers are not necessarily
valid. For instance they may have been maliciously set to very large
values with the intention to cause DoS (large memory allocation, stack
overflow). In these cases we want to detect the invalid size as early
as possible.

This commit introduces a counter which verifies that the number of
written bytes corresponds to the advertized width/length.

See commit 8ee3352 for details.

Signed-off-by: Young Xiao <YangX92@hotmail.com>
    @Yoha-test @YangY-Xiao
    Yoha-test authored and YangY-Xiao committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    21399f6 View commit details
    Browse the repository at this point in the history

  2. bmp_read_rle4_data(): avoid potential infinite loop

    @Yoha-test @YangY-Xiao
    Yoha-test authored and YangY-Xiao committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    3aef207 View commit details
    Browse the repository at this point in the history