Merge pull request #2340 from uccser/2339-bug-ci-failing-style-check

fix: style test failing, do not compare types, for exact checks use is
uccser · Dec 20, 2023 · c092c4d · c092c4d
2 parents 288a5de + c9ba78c
commit c092c4d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/csunplugged/tests/helpers.py b/csunplugged/tests/helpers.py
@@ -36,9 +36,9 @@ def bool_to_yes_no(value, error_on_invalid=False):
     Raises:
         ValueError if value isn't "yes" or "no".
     """
-    if type(value) == bool and value:
+    if type(value) is bool and value:
         return "yes"
-    elif type(value) == bool:
+    elif type(value) is bool:
         return "no"
     elif error_on_invalid:
         raise ValueError("Expected True or False.")

diff --git a/csunplugged/utils/bool_to_yes_no.py b/csunplugged/utils/bool_to_yes_no.py
@@ -16,9 +16,9 @@ def bool_to_yes_no(value, error_on_invalid=False):
     Raises:
         ValueError if value isn't "yes" or "no".
     """
-    if type(value) == bool and value:
+    if type(value) is bool and value:
         return "yes"
-    elif type(value) == bool:
+    elif type(value) is bool:
         return "no"
     elif error_on_invalid:
         raise ValueError("Expected True or False.")