-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scratchpad Config #383
Scratchpad Config #383
Conversation
Can we make this stuff belong in testchipip instead? 1) it reduces code bloat in Chipyard core. 2) a backing scratchpad feels like a "testchip" feature. |
None of this code is "new" per-se... it is just using Rocket Chip. IMO |
Even if all the components are Rocket Chip, it adds a new Field and a new Trait. The guidelines for Keys/Traits in #347 specified that keys and traits should be defined in submodules, since they deal with custom modifications that not all people will use. The only exception to this rule is for the example widgets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine- how did you test it?
@jerryz123 I think this should go here. I think you might be able to make an argument that the stuff in TopCakes
could go into testchipip, but it's so small I think it's overkill. The rest obviously has to go in chipyard.
While I agree that As for the testing, I just finished running the asm/bmark tests and they passed. |
9a44f6c
to
cfccf1c
Compare
d33251f
to
1e91efa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1e91efa
to
ea8f255
Compare
Fixes #381.
Adds a configuration that removes off-chip memory interface in favor of a configurable scratchpad hanging off the
mbus
. This builds Verilog but I haven't tested any code with this.Based on #347 so this must go in after that. (Ill change the base branch when the other PR is done).