-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Checkpointing Script + Docs #1911
Conversation
generators/chipyard/src/main/scala/config/PeripheralDeviceConfigs.scala
Outdated
Show resolved
Hide resolved
Once #1912 is merged, I'll rebase this PR and clean up the commits. However, this currently works consistently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be rebased on dev to clean the commit history
22df926
to
bafc77c
Compare
Fixed and more robust ckpt script Support changing PMPs in SpikeTile configs New ckpt specific configs Dedup + fix SpikeTile configs Bump FireMarshal for HTIF-only serial console Linux version Many docs + comments for clarification
bafc77c
to
8fb201d
Compare
@@ -16,7 +16,9 @@ import freechips.rocketchip.util._ | |||
import freechips.rocketchip.tile._ | |||
import freechips.rocketchip.prci._ | |||
|
|||
case class SpikeCoreParams() extends CoreParams { | |||
case class SpikeCoreParams( | |||
nPMPs: Int = 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to just make this a hard default to 0 in the params, rather than introducing a default that is seldom useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are trying to match Rocket w/ the configurations maybe this should be set to 8 by default (what Rocket does). IMO it's better to match Rocket then have a specific checkpointing config that has the right arch. state set than have some implicitly set default value that works for one config (Spike) but not for the other (Rocket) when reloading checkpoints.
Ok, it looks like this issue is something to do with SV39 v SV48. I'll just convert all configs to by default use SV39 again (instead of SV48) since SV39 was more thoroughly tested and it works with cospike. I'll update this PR to point to ucb-bar/testchipip#237 |
e188bac
to
0517c46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you force push removing the [ci skip] tag?
I want this PR reviewed and added before bumping this: riscv-software-src/riscv-isa-sim#1721 |
Bumped but still waiting for riscv-software-src/riscv-isa-sim#1721 to fully merge this. |
generators/chipyard/src/main/scala/config/PeripheralDeviceConfigs.scala
Outdated
Show resolved
Hide resolved
Bumped. This is ready for review. |
eff0ad8
to
3750640
Compare
Finally done. |
Various checkpointing fixes + QoL updates:
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?