Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FIFO-fixing for PRCI bus #1563

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Fix FIFO-fixing for PRCI bus #1563

merged 2 commits into from
Jul 21, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Jul 20, 2023

Fragmenter infront of FIFO-fixer needs to track way too many source-Ids

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Fragmenter infront of FIFO-fixer needs to track way too many source-Ids
@jerryz123 jerryz123 requested a review from sagark July 20, 2023 01:43
@jerryz123 jerryz123 changed the title Fix FIFO-fixing Fix FIFO-fixing for PRCI bus Jul 20, 2023
Copy link
Member

@sagark sagark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This solved the issues I was having.

@jerryz123
Copy link
Contributor Author

There is one minor fix to this I'd like to push, it will fix the remaining CI failure. You should apply this fix to your chip as well.

@jerryz123 jerryz123 merged commit 6dc7d6f into main Jul 21, 2023
@jerryz123 jerryz123 deleted the fixfifofixing branch August 18, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants