Feat/heal search debounce #1232
Conversation
…sts can be written and so debouncing works
…earch into a search folder and authored a test for doDebounceSearch
…ay to object to avoid needing spread operator
| @@ -0,0 +1,63 @@ | |||
| import { DiscoveryConfig } from '../../DiscoveryConfig'; | |||
|
|
|||
| interface FilterState { | |||
There was a problem hiding this comment.
this can use the exported interface?
There was a problem hiding this comment.
Good point! The FilterState here has been updated as an import from the Discovery.tsx file.
There was a problem hiding this comment.
overall the debounce logic seems working fine in QA and looks good to me. One minor comment below
There is a bug that if there is a value in the search bar and user switches page, the value will be preserved but the table will show as it has 0 reocrds. But I think this is an existing bug that is not relevent to the change
Thanks @mfshao! I agree that the bug is a preexisting condition, I spent an hour or so working on it and I think it merits a separate ticket. |
Jira Ticket: HP-983
New Features
This adds 500ms debouncing to the HEAL search functionality following page load. This uses the lodash debounce API (this library is already included in the code base).
This also adds a unit test for the debouncing functionality.
Improvements
A utils folder has been added containing a Search folder to house the search functionality and to aid in code organization. The filtering functions associated with searching have been moved into this folder to help clean up Discovery.tsx. Unneeded imports were removed from Discovery.tsx.
Screen Shots
With a 500ms debounce
Note that when typing a longer query, such as "intersection" it only searches once