Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent title bar when window inactive #577

Closed
jpnurmi opened this issue Feb 3, 2023 · 3 comments · Fixed by #599
Closed

Transparent title bar when window inactive #577

jpnurmi opened this issue Feb 3, 2023 · 3 comments · Fixed by #599

Comments

@jpnurmi
Copy link
Member

jpnurmi commented Feb 3, 2023

The background of an inactive title bar is transparent, which makes it leak stuff through. It could be a banner like below, or it could be scrollable content. Could we make it opaque instead?

Active Inactive
image image
@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 3, 2023

It's not hard to clip the content but performance-wise it's better to avoid clipping whenever possible. In this case, you wouldn't have to if the title bar was opaque.

We allow customizing the background color so apps can set it to transparent if they want the content below to see through, but it probably should not be the default because it's very uncommon that there's anything interesting behind a window title bar. :)

@Feichtmeier
Copy link
Member

Yes opaque sounds good! I suppose Theme.of(context).colorScheme.background should be correct

@Jupi007
Copy link
Member

Jupi007 commented Feb 3, 2023

Yes opaque sounds good! I suppose Theme.of(context).colorScheme.background should be correct

Yes, this is the correct backdrop color for the titlebar 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants