This repository has been archived by the owner on Feb 25, 2024. It is now read-only.
fix: Improve android support #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feichtmeier
force-pushed
the
Feichtmeier/issue401
branch
from
941b747 to
c8171bc
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a simlified almost pure M3 theme for when yaru is used on android/ios/fuchsia, with only the colorscheme and textheme from the previous code.
The sizes of buttons are currently not working for mobile plus many modifications to elevated, filled buttons, text fields and so on do not work well on android.
This PR also adds the example/android folder to actually use the theme on android
IMO this is a solid solution for when you use yaru.dart on mobile.
@Jupi007 WDYT?
Fixes #401