This repository has been archived by the owner on Feb 25, 2024. It is now read-only.
Menus: use surface variant in dark theme, surface in light theme #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the previously hardcoded
rgb(34,34,34)
color into the color scheme makes it possible to:YaruAutocomplete
.Popup menus look the same as before in both light and dark themes. The only effective change is that
surfaceVariant
has now a different value in the dark theme. I sincerely hope thatsurfaceVariant
was a safe choice for this but it's hard to know where it might be used... 😅Ref: ubuntu/yaru.dart#845
Ref: ubuntu/yaru.dart#668