feat: add caching #150
Merged
feat: add caching #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-loose
force-pushed
the
cache-chart-data
branch
from
114916d to
eca3a5d
Compare
d-loose
requested review from
matthew-hagemann and
sminez
and removed request for
matthew-hagemann
sminez
reviewed
Dec 10, 2024
src/grpc/charts.rs
Outdated
Comment on lines
54
to
59
| if chart.was_cached { | ||
| info!( | ||
| "Using cached chart data for category '{:?}' in timeframe '{:?}'", | ||
| category, timeframe | ||
| ); | ||
| } |
There was a problem hiding this comment.
We said we'd look into the top level task periodically logging cache metrics at a later date but are we wanting to keep this info level logging each time a cached chart is served?
There was a problem hiding this comment.
Ah sorry, this made it's way back in during the rebase - will remove it for now
sminez
previously approved these changes
Dec 10, 2024
Yes, adding |
sminez
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some simple caching logic to prevent too many unnecessary db requests, constant re-calculation of the top charts and spamming snapcraft.io with requests to resolve snap IDs.
get_chart, cached for 24 hours)snap_names (get_snap_name, cached indefinitely, currently used in the category updates, will also be used for the charts when migrating from IDs to names)get_by_snap_id, cached for 24 hours)Personal vote data (
get_all_by_client_hash) is not cached.Caching can be disabled at compile time (for integration tests) via the
SKIP_CACHEenvironment variable.UDENG-5543