Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove alternatives workaround #721

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

p5
Copy link
Member

@p5 p5 commented Feb 20, 2025

Closes #623

This should no longer be necessary since the version from the GitHub issue linked above has been released to all images.

@bsherman How do I know if this PR is safe to merge? I don't think we'll detect this in CI?

@p5 p5 requested a review from castrojo as a code owner February 20, 2025 16:54
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 20, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 20, 2025
@castrojo castrojo enabled auto-merge February 20, 2025 17:53
@castrojo castrojo added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit f19572e Feb 20, 2025
18 checks passed
@castrojo castrojo deleted the remove-alternatives-workaround branch February 20, 2025 18:08
@bsherman
Copy link
Contributor

@bsherman How do I know if this PR is safe to merge? I don't think we'll detect this in CI?

The primary symptom solved by the workaround was failed RPM package installs (sometimes silently) due to some alternatives interactions in rpm post-install scripts.

It seems I was confident in the issue you referenced, so let's hope I was correct. 😎

bsherman added a commit to ublue-os/bluefin that referenced this pull request Feb 21, 2025
`main` has removed the workaround since upstream should have fixed it.

Relates: ublue-os/main#721
bsherman added a commit to bsherman/bos that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update build scripts re: alternatives workaround
4 participants