Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): Enable Docker Building, GHA Log Grouping #2114

Merged
merged 11 commits into from
Jan 6, 2025
Merged

feat(ci): Enable Docker Building, GHA Log Grouping #2114

merged 11 commits into from
Jan 6, 2025

Conversation

m2Giles
Copy link
Member

@m2Giles m2Giles commented Jan 5, 2025

No description provided.

m2Giles added 10 commits January 5, 2025 17:37
@m2Giles
feat(ci): Enable Docker Building, GHA Log Grouping
9683afa 
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
@m2Giles
more GHA grouping
3e183f5 
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
@m2Giles
more gha group logs
4a9906b 
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
@m2Giles
make gha logging stand out more
9073568 
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
@m2Giles
fix whats breaking?
b0ff829 
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
@m2Giles
more grouping
75256a2 
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
@m2Giles
Merge branch 'main' into justfile
8644189
@m2Giles
add grouping inside of justfile
a3c96b5 
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
@m2Giles
don't set +x
a237f88 
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
@m2Giles
Merge branch 'main' into justfile
c5a3002
@m2Giles m2Giles marked this pull request as ready for review January 6, 2025 21:03
@m2Giles m2Giles requested a review from castrojo as a code owner January 6, 2025 21:03
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. github_actions Pull requests that update GitHub Actions code labels Jan 6, 2025
@m2Giles
Copy link
Member Author

m2Giles commented Jan 6, 2025

@tulilirockz this should have the changes for opencontainers labelling.

@m2Giles
figure out IFS later
2f1d027 
Signed-off-by: m2 <69128853+m2Giles@users.noreply.github.com>
@tulilirockz
Copy link
Collaborator

@tulilirockz this should have the changes for opencontainers labelling.

Nice! Thank you!!

tulilirockz
tulilirockz approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@tulilirockz tulilirockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, builds nice, LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 6, 2025
@m2Giles m2Giles added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 54d8022 Jan 6, 2025
35 checks passed
@m2Giles m2Giles deleted the justfile branch January 6, 2025 22:56
This was referenced Jan 7, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulilirockz tulilirockz tulilirockz approved these changes

@castrojo castrojo Awaiting requested review from castrojo castrojo is a code owner

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m2Giles @tulilirockz