Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change switch-input-source keybinding #1146

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

p5
Copy link
Member

@p5 p5 commented Apr 15, 2024

This <Super>Space keybinding should be used for the Search Light extension since it matches Alfred (MacOS).
This PR is untested, and I will not be around to test it until tomorrow.

@p5 p5 requested a review from castrojo as a code owner April 15, 2024 22:03
castrojo
castrojo previously approved these changes Apr 15, 2024
@lauretano
Copy link

lauretano commented Apr 15, 2024

one thing to note, there's switch-input-source and switch-input-source-backward, this has the effect of setting them to be the same shortcut. This doesn't seem to cause any problem since either shortcut brings up the switching OSD, and this still has the effect of freeing up super+space to be used by the search light extension. The "backward" shortcut could be removed to clear up any potential confusion.

@p5
Copy link
Member Author

p5 commented Apr 15, 2024

one thing to note, there's switch-input-source and switch-input-source-backwards, this has the effect of setting them to be the same shortcut. This doesn't seem to cause any problem since either shortcut brings up the switching OSD, and this still has the effect of freeing up super+space to be used by the search light extension. The "backwards" shortcut could be removed to clear up any potential confusion.

@lauretano
Good call! Thanks!
I have made the change which I believe unsets that -backwards keybinding, but as with the other change in this PR, I am not in a position to test it.

@p5 p5 requested a review from castrojo April 15, 2024 22:29
@p5 p5 merged commit cf11ba9 into main Apr 16, 2024
28 of 40 checks passed
@p5 p5 deleted the change-default-switch-input-source-keybinding branch April 16, 2024 14:56
p5 added a commit that referenced this pull request Apr 16, 2024
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants