use static query as much as possible instead of dynamic query #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroki6
pushed a commit
that referenced
this pull request
Feb 20, 2023
This reverts commit 6d2770a, reversing changes made to dda522a. Revert "Merge pull request #93 from ubirch/fix/remove-dynamic-query-for-oom" This reverts commit 5aaec60, reversing changes made to bb1bcf2. Revert "Merge pull request #91 from ubirch/fix/remove-dynamic-query-for-oom" This reverts commit bb1bcf2, reversing changes made to f634424. Revert "use quill 3.12.0" This reverts commit f634424. Revert "Merge pull request #90 from ubirch/feature/UC-1784-update-cassandra" This reverts commit 7791e95, reversing changes made to f50d2de.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we saw the memory consumption keeps growing in the development environment because many
scala.collection.mutable.LinkedEntryobjects stay alive and are used inside of the quill, I assume that using dynamic queries is the main cause.It might be related to the issue below.
NormalizeCaching cache grows without bound
Therefore, I want to try to use static queries as much as possible, then do a load test and see how the memory consumption goes.