feat: fixed followup and unassignment #413

wannacfuture · 2023-06-18T14:36:49Z

Resolves #408

QA issue1: https://github.com/wannacfuture/Battleship/issues/20#issuecomment-1596167479
There, the user assigned that issue 5 days ago, but never did any activity. So the bot follows him up.
QA issue2: https://github.com/wannacfuture/Battleship/issues/17#issuecomment-1596165596
There, the use assigned that issue last week but never did any activity. So the bot releases the bounty

IMPORTANT

Here, the bot monitors the activity of bounty hunter.
And last activity time means the latest time among:

last comment time on the issue from the bounty hunter.
committed time of last commit on the linked pull request from the bounty hunter.
created time of last comment on the linked pull request from the bounty hunter.

Test successful.

netlify · 2023-06-18T14:37:02Z

✅ Deploy Preview for ubiquibot-staging ready!

Name	Link
🔨 Latest commit	`7a573c8`
🔍 Latest deploy log	https://app.netlify.com/sites/ubiquibot-staging/deploys/648f46fc6161a20008ee5d44
😎 Deploy Preview	https://deploy-preview-413--ubiquibot-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

0x4007 · 2023-06-18T16:05:50Z

The linked examples look good but what was the root cause of the issue?

This bounty requires that you figure out the root cause of the issue, as well as provide a fix.

src/helpers/issue.ts

wannacfuture · 2023-06-18T18:01:22Z

Yea, the root cause of the issue was that the mentioned comment of that bounty hunter is created less than a week before.
So the bot identified that issue as it has activity within the week so, it didn't unassign the hunter.

wannacfuture · 2023-06-19T10:46:16Z

@0xcodercrane , could you review this one?

0xcodercrane

The codebase looks good. QA is also good but @Draeieg needs to verify it finally.

0x4007 · 2023-06-19T15:12:44Z

QA is also good but @Draeieg needs to verify it finally.

Shouldn't you request a review from Draeieg if you need QA?

wannacfuture · 2023-06-19T15:38:43Z

@Draeieg ? 😊

0x4007 · 2023-06-22T09:55:43Z

Yea, the root cause of the issue was that the mentioned comment of that bounty hunter is created less than a week before.
So the bot identified that issue as it has activity within the week so, it didn't unassign the hunter.

I don't believe that's correct. The reason why I made the issue is because it had already been a full week, and I expected that they should have been unassigned. @Draeieg do you have any theories?

wannacfuture · 2023-06-22T10:23:06Z

I don't believe that's correct. The reason why I made the issue is because it had already been a full week, and I expected that they should have been unassigned. @Draeieg do you have any theories?

No, it had already been a full week, but there is a comment of the hunter on the issue within the week before.
Could you take a closer look? @pavlovcik ?

0x4007 · 2023-06-23T07:17:11Z

The easiest way to prove your point to me is if you can link the two comments you are talking about here.

wannacfuture · 2023-06-23T08:43:49Z

on the issue #176 (comment) ,
the bot commented about the time limit on #176 (comment) .
You see? the created time is Jun 8 2023 12:09 PM GMT+9
then Lets move to this comment : #176 (comment)
the created time is Jun 9 2023 7:03 AM GMT+9
Then, as you can see - @pavlovcik , you mentioned about that issue that it is not unassigned, but actually at that time - Jun 16 2023 6:57 AM GMT +9 I think you can calculate the time - it has been less than a week!! right?
then the hunter added comment at Jun 16 2023 5:44 PM GMT +9 (plz don't think the bot works real-time, lol)
if the hunter added comment the day after, or something the bot would have unassigned it but luckily it wasn't.

0x4007 · 2023-06-23T10:47:58Z

The bot is supposed to follow up with a comment within four days. The comment examples you provided are more than four days apart. Perhaps I need to review this when I'm not tired. @rndquu what do you think about this?

rndquu · 2023-06-23T11:51:57Z

@0xcodercrane do we have FOLLOW_UP_TIME and DISQUALIFY_TIME env variables set in the netlify prod environment? If so then what are their values?

wannacfuture · 2023-06-23T11:56:20Z

@rndquu , The bot add comment : "Do you have any update ...?" after FOLLOW_UP_TIME has passed.
And the bot unassines the hunter after DISQUALIFY_TIME has passed.

Seems something went wrong at that moment(FOLLOW_UP_TIME has not been set or something).
I think we need to take a look for some period if my MR is working. @pavlovcik

0x4007 · 2023-06-24T08:23:00Z

@0xcodercrane do we have FOLLOW_UP_TIME and DISQUALIFY_TIME env variables set in the netlify prod environment? If so then what are their values?

You can verify in the future by logging into @ubiquity-bounties and then logging into netlify.
Great diagnosis rndquu!

Production

Staging

I just set FOLLOW_UP_TIME to 4
I just set DISQUALIFY_TIME to 7

Does that mean that this pull request was unnecessary?

rndquu · 2023-06-24T08:37:16Z

@0xcodercrane do we have FOLLOW_UP_TIME and DISQUALIFY_TIME env variables set in the netlify prod environment? If so then what are their values?

You can verify in the future by logging into @ubiquity-bounties and then logging into netlify.

Great diagnosis rndquu!

I just set FOLLOW_UP_TIME to 4

I just set DISQUALIFY_TIME to 7

Does that mean that this pull request was unnecessary?

You can verify in the future by logging into @ubiquity-bounties

You mean authenticate by login and password? I don't have a password for the @ubiquity-bounties account

I just set FOLLOW_UP_TIME to 4, I just set DISQUALIFY_TIME to 7

This breaks unassignment because here ms is used which converts ms(4) to 4ms string value which breaks unassignment. You should either delete FOLLOW_UP_TIME and DISQUALIFY_TIME env variables (this way default values will be used) either set them to their correct default string values

Does that mean that this pull request was unnecessary?

No, this PR is necessary. I simply wanted to check whether env variables (FOLLOW_UP_TIME and DISQUALIFY_TIME) are set and that their values are correct.

0x4007 · 2023-06-24T08:52:48Z

You mean authenticate by login and password? I don't have a password for the @ubiquity-bounties account

Shared in direct message.

This breaks unassignment because here ms is used which converts ms(4) to 4ms string value which breaks unassignment. You should either delete FOLLOW_UP_TIME and DISQUALIFY_TIME env variables (this way default values will be used) either set them to their correct default string values

Okay then try logging in and resetting the values to what you think makes sense.

rndquu · 2023-06-24T14:13:49Z

You mean authenticate by login and password? I don't have a password for the @ubiquity-bounties account

Shared in direct message.

This breaks unassignment because here ms is used which converts ms(4) to 4ms string value which breaks unassignment. You should either delete FOLLOW_UP_TIME and DISQUALIFY_TIME env variables (this way default values will be used) either set them to their correct default string values

Okay then try logging in and resetting the values to what you think makes sense.

@0xcodercrane notice that I've updated env variables in prod netlify deploy to these values (which are used by default if FOLLOW_UP_TIME and DISQUALIFY_TIME are not set at all):

FOLLOW_UP_TIME="4 days"
DISQUALIFY_TIME="7 days"

@Draeieg FYI on staging we have the following "unassign" setup:

FOLLOW_UP_TIME="24 hrs"
DISQUALIFY_TIME="25 hrs"

Draeieg · 2023-06-24T14:15:54Z

You mean authenticate by login and password? I don't have a password for the @ubiquity-bounties account

Shared in direct message.

This breaks unassignment because here ms is used which converts ms(4) to 4ms string value which breaks unassignment. You should either delete FOLLOW_UP_TIME and DISQUALIFY_TIME env variables (this way default values will be used) either set them to their correct default string values

Okay then try logging in and resetting the values to what you think makes sense.

@0xcodercrane notice that I've updated env variables in prod netlify deploy to these values (which are used by default if FOLLOW_UP_TIME and DISQUALIFY_TIME are not set at all):
FOLLOW_UP_TIME="4 days"
DISQUALIFY_TIME="7 days"
@Draeieg FYI on staging we have the following "unassign" setup:
FOLLOW_UP_TIME="24 hrs"
DISQUALIFY_TIME="25 hrs"

Yes, I was the one who requested those times to facilitate QA

Draeieg · 2023-06-24T19:26:10Z

hey dm me at https://t.me/Draeieg @wannacfuture

0x4007 · 2023-06-25T03:14:59Z

@Draeieg I can give you direct access to change environment variables if needed just dm me for credentials.

feat: fixed followup and unassignment

ca68443

wannacfuture requested a review from 0xcodercrane as a code owner June 18, 2023 14:36

0x4007 suggested changes Jun 18, 2023

View reviewed changes

src/helpers/issue.ts Outdated Show resolved Hide resolved

feat: camelCase

7a573c8

wannacfuture requested a review from 0x4007 June 18, 2023 18:03

0xcodercrane approved these changes Jun 19, 2023

View reviewed changes

0x4007 approved these changes Jun 19, 2023

View reviewed changes

0x4007 requested a review from Draeieg June 19, 2023 15:12

Draeieg approved these changes Jun 19, 2023

View reviewed changes

0xcodercrane merged commit 8bb968f into ubiquity:development Jun 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: fixed followup and unassignment #413

feat: fixed followup and unassignment #413

wannacfuture commented Jun 18, 2023 •

edited

Loading

netlify bot commented Jun 18, 2023 •

edited

Loading

0x4007 commented Jun 18, 2023 •

edited

Loading

wannacfuture commented Jun 18, 2023

wannacfuture commented Jun 19, 2023

0xcodercrane left a comment

0x4007 commented Jun 19, 2023

wannacfuture commented Jun 19, 2023 •

edited

Loading

0x4007 commented Jun 22, 2023 •

edited

Loading

wannacfuture commented Jun 22, 2023

0x4007 commented Jun 23, 2023

wannacfuture commented Jun 23, 2023

0x4007 commented Jun 23, 2023 •

edited

Loading

rndquu commented Jun 23, 2023

wannacfuture commented Jun 23, 2023

0x4007 commented Jun 24, 2023 •

edited

Loading

rndquu commented Jun 24, 2023 •

edited

Loading

0x4007 commented Jun 24, 2023

rndquu commented Jun 24, 2023

Draeieg commented Jun 24, 2023

Draeieg commented Jun 24, 2023

0x4007 commented Jun 25, 2023 •

edited

Loading

feat: fixed followup and unassignment #413

feat: fixed followup and unassignment #413

Conversation

wannacfuture commented Jun 18, 2023 • edited Loading

IMPORTANT

netlify bot commented Jun 18, 2023 • edited Loading

✅ Deploy Preview for ubiquibot-staging ready!

0x4007 commented Jun 18, 2023 • edited Loading

wannacfuture commented Jun 18, 2023

wannacfuture commented Jun 19, 2023

0xcodercrane left a comment

Choose a reason for hiding this comment

0x4007 commented Jun 19, 2023

wannacfuture commented Jun 19, 2023 • edited Loading

0x4007 commented Jun 22, 2023 • edited Loading

wannacfuture commented Jun 22, 2023

0x4007 commented Jun 23, 2023

wannacfuture commented Jun 23, 2023

0x4007 commented Jun 23, 2023 • edited Loading

rndquu commented Jun 23, 2023

wannacfuture commented Jun 23, 2023

0x4007 commented Jun 24, 2023 • edited Loading

Production

Staging

rndquu commented Jun 24, 2023 • edited Loading

0x4007 commented Jun 24, 2023

rndquu commented Jun 24, 2023

Draeieg commented Jun 24, 2023

Draeieg commented Jun 24, 2023

0x4007 commented Jun 25, 2023 • edited Loading

wannacfuture commented Jun 18, 2023 •

edited

Loading

netlify bot commented Jun 18, 2023 •

edited

Loading

0x4007 commented Jun 18, 2023 •

edited

Loading

wannacfuture commented Jun 19, 2023 •

edited

Loading

0x4007 commented Jun 22, 2023 •

edited

Loading

0x4007 commented Jun 23, 2023 •

edited

Loading

0x4007 commented Jun 24, 2023 •

edited

Loading

rndquu commented Jun 24, 2023 •

edited

Loading

0x4007 commented Jun 25, 2023 •

edited

Loading