Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/perf #167

Merged
merged 20 commits into from
Feb 20, 2024
Merged

Fix/perf #167

merged 20 commits into from
Feb 20, 2024

Conversation

0x4007
Copy link
Member

@0x4007 0x4007 commented Feb 20, 2024

Resolves #130

I dynamically load from chainlist.org and then include it in the build process (that way we don't need to add support for nodejs APIs like fs)

@0x4007 0x4007 mentioned this pull request Feb 20, 2024
@0x4007 0x4007 marked this pull request as ready for review February 20, 2024 11:00
@0x4007 0x4007 requested a review from rndquu as a code owner February 20, 2024 11:00
@0x4007
Copy link
Member Author

0x4007 commented Feb 20, 2024

Not sure why CI is not automatically running on push?

@0x4007
Copy link
Member Author

0x4007 commented Feb 20, 2024

Tested a new clone and yarn build

Still having problems with the ubiquibot submodule.

@FernandVEYRIER @rndquu rfc

m1:pay.ubq.fi nv$ yarn
yarn install v1.22.21
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
success Already up-to-date.
$ git submodule update --init --recursive
Submodule 'lib/chainlist' (https://github.com/DefiLlama/chainlist.git) registered for path 'lib/chainlist'
Submodule 'lib/forge-std' (https://github.com/foundry-rs/forge-std) registered for path 'lib/forge-std'
Submodule 'lib/permit2' (https://github.com/Uniswap/permit2) registered for path 'lib/permit2'
Submodule 'lib/ubiquibot' (https://github.com/ubiquity/ubiquibot) registered for path 'lib/ubiquibot'
Cloning into '/Users/nv/Downloads/pay.ubq.fi/lib/chainlist'...
Cloning into '/Users/nv/Downloads/pay.ubq.fi/lib/forge-std'...
Cloning into '/Users/nv/Downloads/pay.ubq.fi/lib/permit2'...
Cloning into '/Users/nv/Downloads/pay.ubq.fi/lib/ubiquibot'...
Submodule path 'lib/chainlist': checked out '805928372c7a97eec513e8c74c344dd759f07e1c'
Submodule path 'lib/forge-std': checked out 'a2edd39db95df7e9dd3f9ef9edc8c55fefddb6df'
Submodule 'lib/ds-test' (https://github.com/dapphub/ds-test) registered for path 'lib/forge-std/lib/ds-test'
Cloning into '/Users/nv/Downloads/pay.ubq.fi/lib/forge-std/lib/ds-test'...
Submodule path 'lib/forge-std/lib/ds-test': checked out 'cd98eff28324bfac652e63a239a60632a761790b'
Submodule path 'lib/permit2': checked out '4382d768fb549af29f71e02e2c638fb3928d3b4b'
Submodule 'lib/forge-gas-snapshot' (https://github.com/marktoda/forge-gas-snapshot) registered for path 'lib/permit2/lib/forge-gas-snapshot'
Submodule 'lib/forge-std' (https://github.com/foundry-rs/forge-std) registered for path 'lib/permit2/lib/forge-std'
Submodule 'lib/openzeppelin-contracts' (https://github.com/OpenZeppelin/openzeppelin-contracts) registered for path 'lib/permit2/lib/openzeppelin-contracts'
Submodule 'lib/solmate' (https://github.com/rari-capital/solmate) registered for path 'lib/permit2/lib/solmate'
Cloning into '/Users/nv/Downloads/pay.ubq.fi/lib/permit2/lib/forge-gas-snapshot'...
Cloning into '/Users/nv/Downloads/pay.ubq.fi/lib/permit2/lib/forge-std'...
Cloning into '/Users/nv/Downloads/pay.ubq.fi/lib/permit2/lib/openzeppelin-contracts'...
Cloning into '/Users/nv/Downloads/pay.ubq.fi/lib/permit2/lib/solmate'...
Submodule path 'lib/permit2/lib/forge-gas-snapshot': checked out '3c5d52a26169876a144f7690d2f9ef0200eb0791'
Submodule 'lib/forge-std' (https://github.com/foundry-rs/forge-std) registered for path 'lib/permit2/lib/forge-gas-snapshot/lib/forge-std'
Cloning into '/Users/nv/Downloads/pay.ubq.fi/lib/permit2/lib/forge-gas-snapshot/lib/forge-std'...
Submodule path 'lib/permit2/lib/forge-gas-snapshot/lib/forge-std': checked out '2c7cbfc6fbede6d7c9e6b17afe997e3fdfe22fef'
Submodule 'lib/ds-test' (https://github.com/dapphub/ds-test) registered for path 'lib/permit2/lib/forge-gas-snapshot/lib/forge-std/lib/ds-test'
Cloning into '/Users/nv/Downloads/pay.ubq.fi/lib/permit2/lib/forge-gas-snapshot/lib/forge-std/lib/ds-test'...
Submodule path 'lib/permit2/lib/forge-gas-snapshot/lib/forge-std/lib/ds-test': checked out '9310e879db8ba3ea6d5c6489a579118fd264a3f5'
Submodule path 'lib/permit2/lib/forge-std': checked out '27e14b7f2448e5f5ac32719f51fe652aa0b0733e'
Submodule 'lib/ds-test' (https://github.com/dapphub/ds-test) registered for path 'lib/permit2/lib/forge-std/lib/ds-test'
Cloning into '/Users/nv/Downloads/pay.ubq.fi/lib/permit2/lib/forge-std/lib/ds-test'...
Submodule path 'lib/permit2/lib/forge-std/lib/ds-test': checked out '9310e879db8ba3ea6d5c6489a579118fd264a3f5'
Submodule path 'lib/permit2/lib/openzeppelin-contracts': checked out 'd3ff81b37f3c773b44dcaf5fda212c7176eef0e2'
Submodule path 'lib/permit2/lib/solmate': checked out '8d910d876f51c3b2585c9109409d601f600e68e1'
Submodule 'lib/ds-test' (https://github.com/dapphub/ds-test) registered for path 'lib/permit2/lib/solmate/lib/ds-test'
Cloning into '/Users/nv/Downloads/pay.ubq.fi/lib/permit2/lib/solmate/lib/ds-test'...
Submodule path 'lib/permit2/lib/solmate/lib/ds-test': checked out '9310e879db8ba3ea6d5c6489a579118fd264a3f5'
fatal: remote error: upload-pack: not our ref 9288dd2c4da4a8ab37409e7ec38ff90d560295d2
fatal: Fetched in submodule path 'lib/ubiquibot', but it did not contain 9288dd2c4da4a8ab37409e7ec38ff90d560295d2. Direct fetching of that commit failed.
error Command failed with exit code 128.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
m1:pay.ubq.fi nv$ yarn build
yarn run v1.22.21
$ run-s utils:hash utils:build
$ git rev-parse --short HEAD > static/commit.txt
$ tsx build/esbuild-build.ts
        esbuild complete
✨  Done in 1.66s.

Looks like it doesn't exist lol I guess we need to reference a commit after its merged in or else the hash is changed or something. Not exactly sure what's going on here. ubiquity/ubiquibot@9288dd2

@rndquu
Copy link
Member

rndquu commented Feb 20, 2024

Not sure why CI is not automatically running on push?

Looks like you fixed it here 935771e

@0x4007 0x4007 marked this pull request as draft February 20, 2024 12:28
@rndquu
Copy link
Member

rndquu commented Feb 20, 2024

Can't reproduce the error with ubiquibot submodule in this PR at the latest commit

rndquu@User-MBP pay.ubq.fi % git submodule update --init --recursive
Submodule 'lib/chainlist' (https://github.com/DefiLlama/chainlist.git) registered for path 'lib/chainlist'
Cloning into '/Users/rndquu/Public/projects/frontend/pay.ubq.fi/lib/chainlist'...
Submodule path 'lib/chainlist': checked out '805928372c7a97eec513e8c74c344dd759f07e1c'
Submodule path 'lib/ubiquibot': checked out 'cb084909ab332f67bba271b5a17b907d21716bd1'

rndquu@User-MBP pay.ubq.fi % git --version
git version 2.39.2 (Apple Git-143)

@0x4007
Copy link
Member Author

0x4007 commented Feb 20, 2024

Can't reproduce the error with ubiquibot submodule in this PR at the latest commit

rndquu@User-MBP pay.ubq.fi % git submodule update --init --recursive
Submodule 'lib/chainlist' (https://github.com/DefiLlama/chainlist.git) registered for path 'lib/chainlist'
Cloning into '/Users/rndquu/Public/projects/frontend/pay.ubq.fi/lib/chainlist'...
Submodule path 'lib/chainlist': checked out '805928372c7a97eec513e8c74c344dd759f07e1c'
Submodule path 'lib/ubiquibot': checked out 'cb084909ab332f67bba271b5a17b907d21716bd1'

rndquu@User-MBP pay.ubq.fi % git --version
git version 2.39.2 (Apple Git-143)

Sorry I didn't make it clear. I fixed it at fac72dd

@ubiquity-os-deployer
Copy link

@0x4007 0x4007 marked this pull request as ready for review February 20, 2024 14:11
@0x4007 0x4007 merged commit 7d88536 into ubiquity:main Feb 20, 2024
1 check passed
@0x4007 0x4007 deleted the fix/perf branch February 20, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch Fastest RPC For Rewards dApp
2 participants