-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: retry plugin #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems odd to use +
to coerce into a number instead of using Number()
@gentlementlegen I think something changed and now tests are failing.
It changed from Why are we testing on real Github issues, it seems prone to bugs like these? Is there any particular reason why we can't mock github issues and comments? I still haven't figured out how to run tests on my local machine so I have to rely on Github actions :D |
@whilefoo It must be because I figured out yesterday that if a user has the organization in private, the bot would consider that you are a contributor and not a collaborator. So now that I made it public so I became a COLLABORATOR. These tests were not mocked somehow hence the difference now. You can see in the conflicts that I made the required changes to mock all of these so this should not happen anymore. PS: sorry for the conflicts |
@whilefoo The logic works however the posted message is wrong (test run here) so you might want to serialize the object. |
Seems to work fine: Meniole#6 (comment) |
resolves #66