fix: format decimal precision problem #172
Conversation
| @@ -127,7 +127,7 @@ export class ContentEvaluatorModule implements Module { | |||
| currentComment.score = { | |||
| ...(currentComment.score || { multiplier: 0 }), | |||
| relevance: new Decimal(currentRelevance).toNumber(), | |||
| reward: currentReward.toNumber(), | |||
| reward: new Decimal(currentReward).mul(100).round().div(100).toNumber(), | |||
There was a problem hiding this comment.
Multiplying and dividing seems wrong. It just cancels itself out.
There was a problem hiding this comment.
@0x4007 It doesn't because of the round, so this basically is a 3 decimal rounding operation. But I don't think this is necessary because Decimaljs can handle an "infinite" amount of decimals. currentReward should be a finite number during all operations.
There was a problem hiding this comment.
Just to clarify, are you suggesting that rounding should be avoided altogether to keep maximum precision until the final display stage? I understood from your comment that decimal.js can handle high precision throughout all operations without the need for intermediate rounding. If so, would it be preferable to apply formatting only at the end for display purposes, rather than during calculations? @gentlementlegen
Resolves #77
Offering a solution to the precision problem @0x4007 @gentlementlegen
By scaling, flooring, and then displaying, you retain the intended precision without triggering floating-point issues