Merge pull request #278 from gentlementlegen/fix/spec-prio-multiplier

.gitattributes

@@ -1,2 +1,4 @@
 dist/** linguist-generated
-bun.lockb linguist-generated
+bun.lockb linguist-generated
+bun.lock linguist-generated
+test/__mocks__/ linguist-generated

README.md

@@ -37,7 +37,7 @@ At the heart of the system is a content evaluation module that assigns monetary
    - Removes user commands (starting with /) and bot responses
    - Filters out quoted text (starting with >)
    - Removes HTML comments and footnotes
-   - For assigned users, considers comment timestamps to optionally exclude those posted during assignment periods, to reduce gaming 
+   - For assigned users, considers comment timestamps to optionally exclude those posted during assignment periods, to reduce gaming
    - Processes linked pull request comments through GraphQL API
    - Handles minimized/hidden comments
    - Credits only unique links to prevent duplicates

src/parser/content-evaluator-module.ts

@@ -1,9 +1,13 @@
+import { TypeBoxError } from "@sinclair/typebox";
 import { Value } from "@sinclair/typebox/value";
+import { postComment } from "@ubiquity-os/plugin-sdk";
 import Decimal from "decimal.js";
 import { encodingForModel } from "js-tiktoken";
+import ms, { StringValue } from "ms";
 import OpenAI from "openai";
-import { commentEnum, CommentKind, CommentType } from "../configuration/comment-types";
+import { CommentAssociation, commentEnum, CommentKind, CommentType } from "../configuration/comment-types";
 import { ContentEvaluatorConfiguration } from "../configuration/content-evaluator-config";
+import { retry } from "../helpers/retry";
 import { IssueActivity } from "../issue-activity";
 import {
   AllComments,
@@ -15,10 +19,6 @@ import {
 import { BaseModule } from "../types/module";
 import { ContextPlugin } from "../types/plugin-input";
 import { GithubCommentScore, Result } from "../types/results";
-import { postComment } from "@ubiquity-os/plugin-sdk";
-import { retry } from "../helpers/retry";
-import ms, { StringValue } from "ms";
-import { TypeBoxError } from "@sinclair/typebox";
 
 /**
  * Evaluates and rates comments.
@@ -139,7 +139,11 @@ export class ContentEvaluatorModule extends BaseModule {
       }
 
       const currentReward = new Decimal(currentComment.score?.reward ?? 0);
-      const priority = currentComment.score?.priority ?? 1;
+      const priority =
+        // We do not apply priority multiplier on issue specification
+        currentComment.score?.priority && !(currentComment.type & CommentAssociation.SPECIFICATION)
+          ? currentComment.score.priority
+          : 1;
 
       currentComment.score = {
         ...(currentComment.score || { multiplier: 0 }),

tests/process.issue.test.ts

@@ -18,7 +18,7 @@ import dbSeed from "./__mocks__/db-seed.json";
 import { server } from "./__mocks__/node";
 import contentEvaluatorResults from "./__mocks__/results/content-evaluator-results.json";
 import dataPurgeResults from "./__mocks__/results/data-purge-result.json";
-import eventincentivesResults from "./__mocks__/results/event-incentives-results.json";
+import eventIncentivesResults from "./__mocks__/results/event-incentives-results.json";
 import formattingEvaluatorResults from "./__mocks__/results/formatting-evaluator-results.json";
 import githubCommentResults from "./__mocks__/results/github-comment-results.json";
 import githubCommentAltResults from "./__mocks__/results/github-comment-zero-results.json";
@@ -314,7 +314,7 @@ describe("Modules tests", () => {
     ];
     await processor.run(activity);
     const result = JSON.parse(processor.dump());
-    expect(result).toEqual(eventincentivesResults);
+    expect(result).toEqual(eventIncentivesResults);
   });
 
   it("Should generate permits", async () => {