fix: signature check

[gentlementlegen]

Resolves #8

[gentlementlegen]

Will need someone who has access to the UBIQUIBOT_PRIVATE_KEY to run the following:

openssl rsa -in UBIQUIBOT_PRIVATE_KEY.pem -pubout -out UBIQUIBOT_PUBLIC_KEY.pem

Or some equivalent to generate the matching public key and then set en environment variable UBIQUIBOT_PUBLIC_KEY with that value. Might be worth setting across the organization since every Worker will have to check this, thanks!

[0x4007]

then set en environment variable UBIQUIBOT_PUBLIC_KEY

Where

[0x4007]

then set en environment variable UBIQUIBOT_PUBLIC_KEY

Where

I added it to this repository's secrets.

[whilefoo]

Might be worth setting across the organization since every Worker will have to check this, thanks!

the public key will be hardcoded in the SDK

[0x4007]

UBIQUIBOT_PUBLIC_KEY.pem.zip

[gentlementlegen]

@whilefoo not sure to understand then, the plug-ins would need it as well? That's how you did the code within assistive-plugin

[0x4007]

Also I realized this is going to be a problem. How will we handle key rotation?

[whilefoo]

@whilefoo not sure to understand then, the plug-ins would need it as well? That's how you did the code within assistive-plugin

the SDK will be a package that the plugins import and use to setup a HTTP server (worker), the public key of the kernel will be in the SDK but it can also be overriden when using the SDK.

Also I realized this is going to be a problem. How will we handle key rotation?

If the keypair changes we can publish a new version, but a problem will be because plugins won't update to the next version immediately. I assume key changes will be rare so it's fine for now.

[0x4007]

I assume key changes will be rare so it's fine for now.

I think we can plan for annual minimum but quarterly seems prudent. I suppose we should support clear errors for invalid keys.

[gentlementlegen]

@whilefoo Okay thanks for the info. So before that SDK is done, shall I keep the PR on hold?

[0x4007]

@whilefoo Okay thanks for the info. So before that SDK is done, shall I keep the PR on hold?

I think never keep any pull on hold. Merge and then we make a new task to make necessary adjustments later. We never know how long it will take to get the new stuff done.

More thoughts on this philosophy here.

[whilefoo]

I agree, let's merge and I will open a new PR when SDK is ready