Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deploy url #111

Merged
merged 7 commits into from
Dec 18, 2024
Merged

feat: deploy url #111

merged 7 commits into from
Dec 18, 2024

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen mentioned this pull request Dec 18, 2024
Closed
@gentlementlegen
Copy link
Member Author

Seems ncc failed to compile this one: https://github.com/Meniole/command-start-stop/actions/runs/12391955983/job/34590118129
Fixing.

whilefoo
whilefoo approved these changes Dec 18, 2024
View reviewed changes
.github/workflows/worker-deploy.yml
with:
files: |
manifest.json
commit-message: "chore: [skip ci] update manifest.json url"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I didn't know you can skip CI with that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some hidden features of GitHub
https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/skipping-workflow-runs

@gentlementlegen
Copy link
Member Author

It seems that after bun got upgraded to 1.40, ncc started to fail complaining about types. My theory is that bun 1.38 was not resolving package dependencies properly and used typescript 5.5.4 (which compiles fine) instead of 5.6 which fails (also tested with 5.7, same result). Downgraded TypeScript to 5.5.4 and it compiles just fine: https://github.com/Meniole/command-start-stop/actions/runs/12392695131

@gentlementlegen gentlementlegen merged commit b8a6dfc into ubiquity-os-marketplace:development Dec 18, 2024
@gentlementlegen gentlementlegen deleted the feat/url branch December 18, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndquu rndquu rndquu approved these changes

@whilefoo whilefoo whilefoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gentlementlegen @rndquu @whilefoo