test: fixed pull-request test to strictly equal the raw output

tests/pull-request.test.ts

@@ -0,0 +1,132 @@
+import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, jest } from "@jest/globals";
+import { drop } from "@mswjs/data";
+import dotenv from "dotenv";
+import { Context } from "../src/types";
+import { db } from "./__mocks__/db";
+import issueTemplate from "./__mocks__/issue-template";
+import { server } from "./__mocks__/node";
+import { createContext } from "./main.test";
+
+dotenv.config();
+
+const userLogin = "ubiquity-os-author";
+
+type Issue = Context<"issue_comment.created">["payload"]["issue"];
+type PayloadSender = Context["payload"]["sender"];
+
+beforeAll(() => {
+  server.listen();
+});
+
+afterEach(() => {
+  server.resetHandlers();
+});
+
+afterAll(() => server.close());
+
+async function setupTests() {
+  db.users.create({
+    id: 1,
+    login: "user1",
+    role: "contributor",
+  });
+  db.issue.create({
+    ...issueTemplate,
+    labels: [{ name: "Priority: 1 (Normal)", description: "collaborator only" }, ...issueTemplate.labels],
+  });
+  db.repo.create({
+    id: 1,
+    html_url: "",
+    name: "test-repo",
+    owner: {
+      login: "ubiquity",
+      id: 1,
+    },
+    issues: [],
+  });
+}
+
+describe("Pull-request tests", () => {
+  beforeEach(async () => {
+    drop(db);
+    jest.clearAllMocks();
+    jest.resetModules();
+    jest.resetAllMocks();
+    await setupTests();
+  });
+
+  it("Should properly update the close status of a linked pull-request", async () => {
+    const issue = db.issue.findFirst({ where: { id: { equals: 1 } } }) as unknown as Issue;
+    issue.labels = [];
+    const sender = db.users.findFirst({ where: { id: { equals: 1 } } }) as unknown as PayloadSender;
+
+    const context = createContext(issue, sender, "") as Context<"pull_request.opened">;
+    context.eventName = "pull_request.opened";
+    context.payload.pull_request = {
+      html_url: "https://github.com/ubiquity-os-marketplace/command-start-stop",
+      number: 1,
+      user: {
+        id: 1,
+        login: userLogin,
+      },
+    } as unknown as Context<"pull_request.edited">["payload"]["pull_request"];
+    context.octokit = {
+      rest: {
+        pulls: {
+          update: jest.fn(),
+        },
+      },
+      graphql: {
+        paginate: jest.fn(() =>
+          Promise.resolve({
+            repository: {
+              pullRequest: {
+                closingIssuesReferences: {
+                  nodes: [
+                    {
+                      assignees: {
+                        nodes: [],
+                      },
+                      labels: {
+                        nodes: [{ name: "Time: <1 Hour" }],
+                      },
+                    },
+                  ],
+                },
+              },
+            },
+          })
+        ),
+      },
+    } as unknown as Context<"pull_request.edited">["octokit"];
+    jest.unstable_mockModule("@supabase/supabase-js", () => ({
+      createClient: jest.fn(),
+    }));
+    jest.unstable_mockModule("../src/adapters", () => ({
+      createAdapters: jest.fn(),
+    }));
+    const { startStopTask } = await import("../src/plugin");
+    await expect(startStopTask(context)).rejects.toMatchObject({
+      logMessage: {
+        raw: expect.stringContaining("No price label is set to calculate the duration"),
+      },
+    });
+    context.octokit = {
+      ...context.octokit,
+      //@ts-expect-error partial mock of the endpoint
+      paginate: jest.fn(() => []),
+      rest: {
+        ...context.octokit.rest,
+        orgs: {
+          //@ts-expect-error partial mock of the endpoint
+          getMembershipForUser: jest.fn(() => ({ data: { role: "member" } })),
+        },
+      },
+    };
+    await expect(startStopTask(context)).rejects.toMatchObject({
+      logMessage: {
+        raw: "Error: This task does not reflect a business priority at the moment. You may start tasks with one of the following labels: Priority: 1 (Normal), Priority: 2 (Medium), Priority: 3 (High), Priority: 4 (Urgent), Priority: 5 (Emergency)",
+      },
+    });
+  });
+});

tests/start.test.ts

@@ -53,6 +53,7 @@ describe("Collaborator tests", () => {
     drop(db);
     jest.clearAllMocks();
     jest.resetModules();
+    jest.resetAllMocks();
     await setupTests();
   });
 
@@ -68,7 +69,7 @@ describe("Collaborator tests", () => {
     context.adapters = createAdapters(getSupabase(), context);
     await expect(start(context, issue, sender, [])).rejects.toMatchObject({
       logMessage: {
-        diff: "```diff\n! Only collaborators can be assigned to this issue.\n```",
+        diff: expect.stringContaining("Only collaborators can be assigned to this issue"),
         level: "error",
         raw: "Only collaborators can be assigned to this issue.",
         type: "error",
@@ -133,80 +134,6 @@ describe("Collaborator tests", () => {
     await startStopTask(context);
     // Make sure the author is the one who starts and not the sender who modified the comment
     expect(start).toHaveBeenCalledWith(expect.anything(), expect.anything(), { id: 1, login: userLogin }, []);
-    start.mockReset();
-  });
-  it("Should properly update the close status of a linked pull-request", async () => {
-    const issue = db.issue.findFirst({ where: { id: { equals: 1 } } }) as unknown as Issue;
-    issue.labels = [];
-    const sender = db.users.findFirst({ where: { id: { equals: 1 } } }) as unknown as PayloadSender;
-
-    const context = createContext(issue, sender, "") as Context<"pull_request.opened">;
-    context.eventName = "pull_request.opened";
-    context.payload.pull_request = {
-      html_url: "https://github.com/ubiquity-os-marketplace/command-start-stop",
-      number: 1,
-      user: {
-        id: 1,
-        login: userLogin,
-      },
-    } as unknown as Context<"pull_request.edited">["payload"]["pull_request"];
-    context.octokit = {
-      rest: {
-        pulls: {
-          update: jest.fn(),
-        },
-      },
-      graphql: {
-        paginate: jest.fn(() =>
-          Promise.resolve({
-            repository: {
-              pullRequest: {
-                closingIssuesReferences: {
-                  nodes: [
-                    {
-                      assignees: {
-                        nodes: [],
-                      },
-                      labels: {
-                        nodes: [{ name: "Time: <1 Hour" }],
-                      },
-                    },
-                  ],
-                },
-              },
-            },
-          })
-        ),
-      },
-    } as unknown as Context<"pull_request.edited">["octokit"];
-    jest.unstable_mockModule("@supabase/supabase-js", () => ({
-      createClient: jest.fn(),
-    }));
-    jest.unstable_mockModule("../src/adapters", () => ({
-      createAdapters: jest.fn(),
-    }));
-    const { startStopTask } = await import("../src/plugin");
-    await expect(startStopTask(context)).rejects.toMatchObject({
-      logMessage: {
-        raw: expect.stringContaining("No price label is set to calculate the duration"),
-      },
-    });
-    context.octokit = {
-      ...context.octokit,
-      //@ts-expect-error partial mock of the endpoint
-      paginate: jest.fn(() => []),
-      rest: {
-        ...context.octokit.rest,
-        orgs: {
-          //@ts-expect-error partial mock of the endpoint
-          getMembershipForUser: jest.fn(() => ({ data: { role: "member" } })),
-        },
-      },
-    };
-    await expect(startStopTask(context)).rejects.toMatchObject({
-      logMessage: {
-        raw: expect.stringContaining("This task does not reflect a business priority at the moment"),
-      },
-    });
+    start.mockClear();
   });
 });