fix(package): Specify addon as peer dependency #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: react-addons-shallow-compare is now a peer dependency, meaning users must install it separately from react-geosuggest. The peer dependency for react allows one to use either react 0.14 or 0.15. However, the dependency for react-addons-shallow-compare only allows 0.15 versions. For anyone using react 0.14 this causes warnings from npm saying that the peer dependency for react 0.15 (specified by react-addons-shallow-compare) is missing. This completely breaks workflows depending on `npm shrinkwrap`.
|
@ro-ka Any thoughts on this? |
|
@joefiorini Thanks for the PR. Just thought after clicking the merge button that we might need to update the README. So that the user might need to install the peer dependencies. |
|
I found this issue on react-redux-form about using react's internal version of shallow-compare so it is not needed as a peer dependency. davidkpiano/react-redux-form#215 (comment) Happy to submit a pull request if you like the solution. |
|
That sounds like a good solution! Cannot revert the |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where:
happened when running
npm installandhappened when running
npm shrinkwrap.Checklist
BREAKING CHANGE: react-addons-shallow-compare is now a peer dependency,
meaning users must install it separately from react-geosuggest.
The peer dependency for react allows one to use either react 0.14 or
0.15. However, the dependency for react-addons-shallow-compare only
allows 0.15 versions. For anyone using react 0.14 this causes warnings
from npm saying that the peer dependency for react 0.15 (specified by
react-addons-shallow-compare) is missing. This completely breaks
workflows depending on
npm shrinkwrap.