Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set proper service context in client tchannels #781

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

isopropylcyanide
Copy link
Contributor

@isopropylcyanide isopropylcyanide commented Aug 18, 2021

Summary

PR Status Type Impact level
Ready Bug High

Description

  • Set tchannel service name to be the same as server (gateway) name
  • Add another helpful log to be tracked in ELK when the channel is created successfully

Motivation


How was this tested?

  • Tested in local that the new client channels are now passed the same value as of the server

Benchmarks

  • N/A

@isopropylcyanide isopropylcyanide changed the title Set proper service name in dedicated client tchannels Set proper service context in client tchannels Aug 18, 2021
@isopropylcyanide isopropylcyanide self-assigned this Aug 18, 2021
@coveralls
Copy link

coveralls commented Aug 19, 2021

Coverage Status

Coverage increased (+0.002%) to 69.582% when pulling d1cc9ad on fix-tchannel-caller-id into a8c5d9c on master.

@isopropylcyanide isopropylcyanide merged commit ffdb70d into master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants