Set proper service context in client tchannels #781
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Motivation
The newly initiated channels as part of Dedicated TChannel Client Per Callee Service #778 were passed a service name of their client-id while in essence they should use the same service name as the gateway. This is because even though there are dedicated channels now, they still need to talk to the routing sidecar as one unit
When we landed Dedicated TChannel Client Per Callee Service #778 some backends that had ACL enabled had their requests outright rejected by the sidecar router.
How was this tested?
Benchmarks