Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circuit Breaking Per Method #773

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Circuit Breaking Per Method #773

merged 2 commits into from
Jul 7, 2021

Conversation

nkonjeti
Copy link
Contributor

@nkonjeti nkonjeti commented Jul 6, 2021 •
edited
Loading

Changes include:

  • each method in client will have circuit breaker
  • link to ERD:

@nkonjeti nkonjeti marked this pull request as draft July 6, 2021 02:49
@nkonjeti nkonjeti changed the title Circuit Breaking Per Method (TESTING DRAFT) Circuit Breaking Per Method (WIP) Jul 6, 2021
@nkonjeti nkonjeti changed the title Circuit Breaking Per Method (WIP) Circuit Breaking Per Method Jul 6, 2021
@nkonjeti nkonjeti self-assigned this Jul 6, 2021
@coveralls
Copy link

coveralls commented Jul 6, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 69.314% when pulling a024af4 on circuit-breaker-method into 059a110 on master.

@nkonjeti nkonjeti requested a review from tejaswiagarwal July 6, 2021 23:34
@nkonjeti nkonjeti marked this pull request as ready for review July 6, 2021 23:35
tejaswiagarwal
tejaswiagarwal approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@tejaswiagarwal tejaswiagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for getting to the bottom of it and resolving the test issue.

@nkonjeti nkonjeti merged commit c8cde85 into master Jul 7, 2021
isopropylcyanide pushed a commit that referenced this pull request Jul 28, 2021
@isopropylcyanide
Circuit Breaking Per Method (#773)
d83f2df 
* Check for unnecessary file changes

* Fix circuit breaker method name for http client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejaswiagarwal tejaswiagarwal tejaswiagarwal approved these changes

Assignees

@nkonjeti nkonjeti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkonjeti @coveralls @tejaswiagarwal