Add metrics to hystrix #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
added 2 commits
June 18, 2021 14:48
rpatali
reviewed
Jun 20, 2021
Comment on lines
275
to
276
| t := time.Now() | ||
| elapsed := t.Sub(start) |
There was a problem hiding this comment.
nit: can be refactored to time.Now().Sub(start). Having t as a var doesn't add extra clarity here.
rpatali
reviewed
Jun 20, 2021
| @@ -266,7 +267,15 @@ type {{$clientName}} struct { | |||
| } else { | |||
| // We want hystrix ckt-breaker to count errors only for system issues | |||
| var clientErr error | |||
| scope := c.defaultDeps.Scope.Tagged(map[string]string{ | |||
| "client" : "{{$svc.Name}}", | |||
There was a problem hiding this comment.
we should add the methodName too
rpatali
reviewed
Jun 20, 2021
| err = hystrix.DoC(ctx, "{{$clientID}}", func(ctx context.Context) error { | ||
| t := time.Now() | ||
| elapsed := t.Sub(start) | ||
| size := scope.Timer("hystrix-timer") |
There was a problem hiding this comment.
size doesn't suit here, probably timer. You may even just do scope.Timer("hystrix-timer").Record(elapsed) without requiring a new var.
tejaswiagarwal
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Time the hystrics.Doc function called in all the client template codegen file. This is to check that hystrix.Doc isn't slow and isn't taking time from the actual request. This problem was stated in this ticket: https://t3.uberinternal.com/browse/EDGE-7509 . A dashboard will be created to graph time taken by hystrix for each client in Grafana.
From baz_metrics_test.go (client: baz, method: call) :