Extend TestGateway request creation with header multi-values #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpatali
reviewed
Aug 10, 2020
| } | ||
| } | ||
|
|
||
| if err != nil { |
There was a problem hiding this comment.
any reason why this isn't right after where this happens?
There was a problem hiding this comment.
Just noticed its just how other ones are too but I don't think they need to be (or at least the new ones need to be).
There was a problem hiding this comment.
Good catch. I moved them to the correct location in both the old and new functions. Leaving it where it was also had the potential for a nil-pointer dereference with the following block accessing a property on req.
rpatali
approved these changes
Aug 10, 2020
tejaswiagarwal
approved these changes
Aug 10, 2020
vermagav
deleted the
gverma/extend-test-gateway-to-support-header-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use the changes in #733 in services that consume Zanzibar, we extend the
TestGatewayinterface to mirror its existingMakeRequestmethod with one that creates a test request with all, disparate values for each header's key. We choose extending the interface instead of refactoringMakeRequestto preserve backwards compatibility with all of its many consumers.