Support grpc client #592
Merged
Support grpc client #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jacobgreenleaf
approved these changes
Jun 21, 2019
peats-bond
reviewed
Jun 22, 2019
| outbounds[key] = transport.Outbounds{ | ||
| ServiceName: value, | ||
| // TODO: this setup opens one TCP connection to the sidecar router per client | ||
| // Is it better to share the same TCP connection among the clients? |
There was a problem hiding this comment.
yup a single transport is intended to support several outbounds, this is what yarpcfx does :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds grpc client support via yarpc.
The integration is done by creating a yarpc client dispatcher object that manages all grpc clients and making it part of gateway object. The dispatcher is used as a default dependency to create grpc clients. And the dispatcher lifecycle methods are hooked into the gateway lifecycle.