Configurable host tag #570

ChuntaoLu · 2019-02-16T07:47:15Z

A few changes in this PR:

make it configurable for applications to decide whether emit non-runtime metrics with host tag or not. Runtime metrics will always have the host tag.
metrics emitted on logging are removed since they barely provide any value.
when env is not production, make http/tchannel server listen on 127.0.0.1 instead of a non-local IP that is reachable by remote hosts. This prevents the accept incoming network connection firewall dialog from popping up on osx when running tests.

coveralls · 2019-02-16T08:08:08Z

Coverage decreased (-0.05%) to 68.833% when pulling c64a8e4 on lu.tag into 56c1508 on master.

Remove logger metrics

67bd14a

ChuntaoLu force-pushed the lu.tag branch from d7754f6 to 737584e Compare February 16, 2019 07:56

Make it configurable to whether emit metrics with host tag

c64a8e4

ChuntaoLu force-pushed the lu.tag branch from 737584e to c64a8e4 Compare February 16, 2019 07:59

ChuntaoLu requested a review from jacobgreenleaf February 16, 2019 07:59

Chuntao Lu added 2 commits February 18, 2019 13:34

Always emit runtime metrics with host tag

556ff35

Use different IPs between test and production

cc03685

ChuntaoLu force-pushed the lu.tag branch from de35978 to cc03685 Compare February 18, 2019 21:39

jacobgreenleaf approved these changes Feb 19, 2019

View reviewed changes

ChuntaoLu merged commit a57c485 into master Feb 19, 2019

ChuntaoLu deleted the lu.tag branch February 19, 2019 19:55

Provide feedback