Adding more tags for panic metric

uber · Feb 28, 2024 · 41836d7 · 41836d7
1 parent 923df99
commit 41836d7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/runtime/router.go b/runtime/router.go
@@ -301,8 +301,14 @@ func (router *httpRouter) handlePanic(
 	}
 	logger := router.gateway.ContextLogger
 	logger.Error(r.Context(), "A http request handler paniced", zap.Error(err), zap.Int(logFieldResponseStatusCode, http.StatusInternalServerError))
-	router.panicCount.Inc(1)
-
+	m := router.gateway.ContextExtractor.ExtractScopeTags(r.Context())
+	endpointId := m[scopeTagEndpoint]
+	handlerId := m[scopeTagHandler]
+	scopeTags := map[string]string{
+		scopeTagEndpoint: endpointId,
+		scopeTagHandler:  handlerId,
+	}
+	router.gateway.RootScope.Tagged(scopeTags).Counter("runtime.router.panic")
 	http.Error(w,
 		http.StatusText(http.StatusInternalServerError),
 		http.StatusInternalServerError,

diff --git a/runtime/router_test.go b/runtime/router_test.go
@@ -55,6 +55,11 @@ func (s *routerSuite) SetupTest() {
 		},
 	)
 	s.router = NewHTTPRouter(s.gw).(*httpRouter)
+	extractors = &ContextExtractors{
+		ScopeTagsExtractors: []ContextScopeTagsExtractor{scopeExtractor},
+		LogFieldsExtractors: []ContextLogFieldsExtractor{logFieldsExtractors},
+	}
+	s.router.gateway.ContextExtractor = extractors
 }
 
 func (s *routerSuite) TestRouter() {