Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses Bundle utility #322

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

ahmetkgunay
Copy link
Contributor

Swift PM supports referencing bundles using Bundle.main. This breaks integration for anyone building manually or wrapping in a Cocoapods Podspec.
This change uses bundle utilities in each framework to select the correct bundle to load resources from.

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2024

CLA assistant check
All committers have signed the CLA.

@mohssenfathi
Copy link
Contributor

Thanks for catching @ahmetkgunay .
I actually remember fixing this as part of this PR, but it must have gotten lost somewhere.

@mohssenfathi mohssenfathi merged commit 577b706 into uber:develop Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants